This repository has been archived by the owner on Feb 11, 2024. It is now read-only.
Fixed Unity 2019 having no GUI among other issues. #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #234 and #233 and provides complete Unity 2019 support.
!UNITY_2018_OR_NEWER
was replaced by!UNITY_2018_1_OR_NEWER
that 2019 recognizes properly.SceneView.onSceneGUIDelegate
has been replaced bySceneView.duringSceneGui
.UnityEditor.StaticEditorFlags.LightmapStatic
has been replaced byUnityEditor.StaticEditorFlags.ContributeGI
.sceneView.m_SceneLighting
has been replaced bysceneView.sceneLighting
.SceneView.SceneViewState.Toggle
has been replaced bySceneView.SceneViewState.SetAllEnabled
.EditorHelper.SceneViewHasDelegate
has been deprecated.SceneView.duringSceneGui
is an event and C# enforces that it can only be mentioned in conjunction with a += or -= operator. In order to determine whether we are already subscribed I decided to create a boolean with the [NonSerialized] flag to ensure that any script recompilations will reset it.Essentially this:
I tested this new code on Unity 5.3, 2017, 2018 and 2019. Works perfectly.