This repository has been archived by the owner on Feb 11, 2024. It is now read-only.
Make vertex paint experimental #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from sabresaurus
sabresaurus
reviewed
Jan 13, 2019
Scripts/UI/SabreCSGPreferences.cs
Outdated
| @@ -116,6 +116,14 @@ public static void PreferencesGUI() | |||
| SceneView.RepaintAll(); | |||
| } | |||
|
|
|||
| EditorGUILayout.Space(); | |||
| EditorGUI.indentLevel = 1; | |||
There was a problem hiding this comment.
Modifying indent level directly like this is probably bad practice, I'd suggest instead using IndentLevelScope
sabresaurus
reviewed
Jan 13, 2019
| @@ -347,6 +347,54 @@ public static GUIStyle FormatStyle(Color textColor, int fontSize, FontStyle font | |||
| return value; | |||
| } | |||
|
|
|||
| public static T DrawPartialEnumGrid<T>(T value, T[] enabled, params GUILayoutOption[] options) where T : struct, IConvertible | |||
There was a problem hiding this comment.
A /// summary would be handy here indicating how this differs from DrawEnumGrid
sabresaurus
approved these changes
Jan 13, 2019
|
Thanks for the feedback! Fixed up those two things. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the vertex paint mode is not finished, and blocking new releases, I have moved it to a new section in the SabreCSG preferences called "Experimental".
This allows the feature to still exist in SabreCSG but be clear for the users that it is still under development.