Skip to content
This repository was archived by the owner on Feb 11, 2024. It is now read-only.

Toolbar rework #207

Merged
merged 25 commits into from
Jan 12, 2019
Merged

Toolbar rework #207

merged 25 commits into from
Jan 12, 2019

Conversation

jmickle66666666
Copy link
Contributor

@jmickle66666666 jmickle66666666 commented Jan 8, 2019

screenshot 2019-01-08 18 58 08

Addresses #205 #206

  • Moved all non-essential viewport and grid settings to a togglable menu, to clean up the clutter of the toolbar. This allows more space and clearer labels for the moved options.
  • Move the brush count from the toolbar to the CSGModel inspector, since it is not a number that needs to always be immediately referenced.
  • Moved all brush-specific settings and operations to a contextual menu that appears only when brushes are selected. This includes the "Flip X/Y/Z" and "Snap Center" buttons from the Resize Toolbar. As a part of this, BrushUtility.Flip had to be changed to accept Brush instead of PrimitiveBrush
  • Move most of the primitive brushes to a togglable menu, clearing up a lot of space from mostly infrequently used buttons. The cube was kept as it is still a useful button to have on hand at any time. Added a new icon for the "More" option in the primitives menu
  • Reduced the height of the toolbar from two lines to one, since so much space was saved. However, added functionality to split into two lines again in case the scene viewport is too small to show everything
  • Removed the "Prefs" and "Disable" buttons from the toolbar, since they seem to be mostly redundant, and take up unnecessary space.

@sabresaurus sabresaurus self-requested a review January 8, 2019 19:45
@sabresaurus
Copy link
Owner

Firstly great work, personally I think this is a vast improvement.

Some feedback:

screenshot 2019-01-08 19 44 57

  • Seems like some of the text is light grey on my Editor (2017.3.1f1), see above image
  • It might make sense to hide Brush Settings when not in Resize of Vertex tools (e.g. it's not useful in the face tool for example and probably gives the wrong context in the other tools too)
  • The >>> button seems to have gone, it's used for the pop-out version of the top UI
  • The checkboxes are considerably harder to press than the old toggles

Some other thoughts that are less pressing:

  • The Flip X,Y,Z buttons might be nicer as GUILayout.Toolbar()
  • The grid settings say "Rotation snapping" and "Snap angle", it might be better to rename it to "Angle snapping" just so it's clear to new users the two settings are the same.
  • Tooltips that show the shortcuts would be nice, e.g. hovering over Grid snapping it could tell you that press / would toggle it.

@jmickle66666666
Copy link
Contributor Author

Ok, fixed up those issues. Thanks for the feedback!

The >>> button I can't account for. I don't remember it myself and definitely didn't touch any code that involved it. I assume it was removed in a previous commit somewhere?

While the checkboxes are more difficult to press than the old toggles, the old toggles are a non-standard UI element to fit the toolbar, whereas the new windows I created were styled after the inspector and followed the layout that does. It's fair to assume any SabreCSG user is already used to using checkboxes in the inspector.

Copy link
Owner

@sabresaurus sabresaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this is a much better UX

@jmickle66666666
Copy link
Contributor Author

brushmenu2

Just discovered an issue with the brush menu; it disappears when you are resizing a brush.

@vertxxyz
Copy link

vertxxyz commented Jan 8, 2019

All the more visibility 😃

Makes more sense in terms of code layout, and fixes an inconsistency with the brush selection information
@jmickle66666666
Copy link
Contributor Author

brushmenu3

Fixed!

@ghost
Copy link

ghost commented Jan 11, 2019

The grid size doesn't change the box size when the digit is higher then 3
2019-01-11_16-52-24

@ghost
Copy link

ghost commented Jan 11, 2019

The viewport settings gui hides when in Face mode
2019-01-11_16-55-31

@jmickle66666666
Copy link
Contributor Author

Thanks for the feedback @Constaneer ! Should all be fixed now

@Henry00IS
Copy link
Collaborator

Brilliant work! Thanks for fixing the toolbar selection too. This new interface will surely help many people! 😁

@Henry00IS Henry00IS merged commit f57fca7 into sabresaurus:master Jan 12, 2019
@jmickle66666666 jmickle66666666 deleted the toolbar-rework branch January 13, 2019 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants