-
Notifications
You must be signed in to change notification settings - Fork 137
Toolbar rework #207
Toolbar rework #207
Conversation
Internally, `ShowBrushesAsWireFrames` still exists and is still used by `PrimitiveBrush.cs`, but it just checks if both the grid and faces are hidden. Flipped polarity of `brushFacesHidden` since the name was opposite to how it worked :)
…abreCSG into toolbar-rework
Also encapsulated NoCSG into the brush mode setting.
Firstly great work, personally I think this is a vast improvement. Some feedback:
Some other thoughts that are less pressing:
|
Ok, fixed up those issues. Thanks for the feedback! The >>> button I can't account for. I don't remember it myself and definitely didn't touch any code that involved it. I assume it was removed in a previous commit somewhere? While the checkboxes are more difficult to press than the old toggles, the old toggles are a non-standard UI element to fit the toolbar, whereas the new windows I created were styled after the inspector and followed the layout that does. It's fair to assume any SabreCSG user is already used to using checkboxes in the inspector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, this is a much better UX
All the more visibility 😃 |
Makes more sense in terms of code layout, and fixes an inconsistency with the brush selection information
I wasn't using unique IDs for the GUILayout.Window function.
Thanks for the feedback @Constaneer ! Should all be fixed now |
Brilliant work! Thanks for fixing the toolbar selection too. This new interface will surely help many people! 😁 |
Addresses #205 #206