This repository has been archived by the owner on Feb 11, 2024. It is now read-only.
Palette Bug Fixes #165
Merged
Palette Bug Fixes #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
sabresaurus
commented
Aug 26, 2018
sabresaurus
commented
- Palette (and Material Palette) now tracks asset path as a fallback in case the GUID changes (observed a lot with scriptable objects)
- Palette also saves more aggressively since Unity doesn't seem to save player prefs unless you run the game
added 2 commits
August 26, 2018 13:29
…in case the GUID changes (observed a lot with scriptable objects) * Palette also saves more aggressively since Unity doesn't seem to save player prefs unless you run the game
Henry00IS
suggested changes
Aug 26, 2018
| { | ||
| // Get the guid, for older versions this is the only thing in the string, for newer versions it's the | ||
| // left side of a colon. Either way Split()[0] works | ||
| string guid = trackedObjectString.Split(':')[0]; |
There was a problem hiding this comment.
warning CS0219: The variable `guid' is assigned but its value is never used
|
After you fixed that warning it also tracks items with GUID changes while Unity is running. The saving works perfectly (without running the game) and I tested it down to Unity 5.3, very nice work @sabresaurus, thank you! 😁 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.