This repository was archived by the owner on Feb 11, 2024. It is now read-only.
Severe performance improvement for brush preview rendering. Fixes #111. #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #111 Found a huge potential performance optimization explains in detail what the problem is.
Instead of creating proper indices on the CPU I now immediately push duplicate vertices to the GPU. I also replaced all of the C# lists with fixed-size arrays reducing the memory usage per call from 1.5 GiB or more to an insignificant amount that no longer freezes the editor.
Performance improvements when:
Attempting to move a single extremely complex brush with 512 polygons, before:
Using this new pull request:
Attempting to view excluded polygons, before:
Attempting to view excluded polygons, after: