Skip to content
This repository was archived by the owner on Feb 11, 2024. It is now read-only.

ShapeEditorWindow.cs error #80

Closed
zabbarian opened this issue Apr 2, 2018 · 5 comments
Closed

ShapeEditorWindow.cs error #80

zabbarian opened this issue Apr 2, 2018 · 5 comments
Labels
priority: high The issue is high priority. status: pull-request A pull request for the issue awaits approval. type: bug The issue is a bug.

Comments

@zabbarian
Copy link

Hi.

I put the SabreCSG-master zip file content into assets folder and i am getting following errors. There is no sabrecsg object in the GameObject menu. I tested with Unity 5.6.5f1 and 2017.1.2f1.

Assets/SabreCSG-master/Scripts/Brushes/CompoundBrushes/Editor/ShapeEditorWindow.cs(990,49): error CS0117: UnityEngine.Screen' does not contain a definition for safeArea'

Assets/SabreCSG-master/Scripts/Brushes/CompoundBrushes/Editor/ShapeEditorWindow.cs(990,113): error CS0117: UnityEngine.Screen' does not contain a definition for safeArea'

Assets/SabreCSG-master/Scripts/Brushes/CompoundBrushes/Editor/ShapeEditorWindow.cs(1350,40): error CS0117: UnityEngine.Screen' does not contain a definition for safeArea'

Assets/SabreCSG-master/Scripts/Brushes/CompoundBrushes/Editor/ShapeEditorWindow.cs(1480,47): error CS0117: UnityEngine.Screen' does not contain a definition for safeArea'

Assets/SabreCSG-master/Scripts/Brushes/CompoundBrushes/Editor/ShapeEditorWindow.cs(1480,131): error CS0117: UnityEngine.Screen' does not contain a definition for safeArea'

@Henry00IS
Copy link
Collaborator

Henry00IS commented Apr 2, 2018

Hey Zabbarian,

the latest version using the Download Zip option or one of the releases?

image

v1.6.1, or the latest master, should have already fixed those errors... I am going to double check to make sure.

@Henry00IS
Copy link
Collaborator

Sorry it seems there is indeed a problem with those Unity versions. I will let you know when it's fixed. May take me a couple minutes.

@Henry00IS
Copy link
Collaborator

Please try this version and let me know if it works properly. :)

@Henry00IS Henry00IS added type: bug The issue is a bug. priority: high The issue is high priority. status: pull-request A pull request for the issue awaits approval. labels Apr 2, 2018
@zabbarian
Copy link
Author

Hi Henry.

I just tested last version you put with both Unity 5.6.5f1 and 2017.1.2f1. It's working fine now with no errors. I can see the "Create CSG" object in the GameObject menu. Thanks.

Henry00IS added a commit that referenced this issue Apr 2, 2018
Compatibility update for older than Unity 2017.2. Fixes #80.
@Henry00IS
Copy link
Collaborator

Thank you so much, that was one of the most important findings yet as it broke all versions of Unity between 5.3 and 2017.2. Thanks again! 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: high The issue is high priority. status: pull-request A pull request for the issue awaits approval. type: bug The issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants