Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Extrude Face puts the face in the wrong place when 2D Shape Editor Brushes not at origin #55

Closed
JudgeGroovyman opened this issue Mar 14, 2018 · 1 comment
Labels
status: pull-request A pull request for the issue awaits approval. type: bug The issue is a bug.

Comments

@JudgeGroovyman
Copy link

Heres a 30second video showing the problem (its easy for me to reproduce)
http://somup.com/cFe2fpVBu1
( its unlisted so anyone who has the link can see it but it won't be in the youtube search results)

Briefly summarizing the video: When I do the "extrude face" function it works on default cubes, but trying to extrude face on a shape made by the 2d shape editor has a problem: the extruded face is placed near the origin and not on the original face where it should be.

The problem seems to only happens if the Shape Editor Brush is not located at 0,0,0
Heres another video showing me narrowing down the problem space
http://somup.com/cFe2f8VBui

How can I help?

Henry00IS added a commit to Henry00IS/SabreCSG that referenced this issue Mar 14, 2018
@Henry00IS
Copy link
Collaborator

Henry00IS commented Mar 14, 2018

You helped a lot by providing those videos. I encountered this bug elsewhere with regular brushes but I moved my CSGModel so I figured that was the reason, but now that you pointed that out I managed to fix all of the bugs and issues:

  • Fixed the world position of newly extruded faces (of a compound brush) ending up at 0,0,0.
  • It now turns them into regular brushes.
  • Fixes brushes ending up at the wrong position when the CSGModel has been moved by the user.

Thanks again! Once this PR is merged this issue will be closed!

@Henry00IS Henry00IS added type: bug The issue is a bug. status: pull-request A pull request for the issue awaits approval. labels Mar 14, 2018
Henry00IS added a commit that referenced this issue Mar 27, 2018
Extrude Compound Brush Faces. Fixes #55.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: pull-request A pull request for the issue awaits approval. type: bug The issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants