adjust tests and tool settings so CI passes

remove undefined assertIsResource from test ignore 'Else branch is unreachable' message on old phpstan lock php-cs-fixer to 3.63.2
sabre-io · Sep 6, 2024 · fc72abd · fc72abd
1 parent e9eca39
commit fc72abd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -44,7 +44,7 @@
         }
     },
     "require-dev": {
-        "friendsofphp/php-cs-fixer": "~2.17.1||^3.63",
+        "friendsofphp/php-cs-fixer": "~2.17.1||3.63.2",
         "phpstan/phpstan": "^0.12",
         "phpunit/phpunit" : "^7.5 || ^8.5 || ^9.6"
     },

diff --git a/phpstan.neon b/phpstan.neon
@@ -5,3 +5,6 @@ parameters:
     -
       message: '!Parameter #3 \$namespace of method XMLWriter::startElementNs\(\) expects string, null given.!'
       path: lib/Writer.php
+    -
+      message: '!Else branch is unreachable because previous condition is always true.!'
+      path: lib/Service.php
diff --git a/tests/Sabre/Xml/ServiceTest.php b/tests/Sabre/Xml/ServiceTest.php
@@ -372,7 +372,6 @@ public function providesEmptyInput()
 </root>
 XML;
         $stream = fopen('php://memory', 'r+');
-        self:assertIsResource($stream);
         fwrite($stream, $xml);
         rewind($stream);
         fclose($stream);