Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use phpunit8 where possible #494

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Use phpunit8 where possible #494

merged 1 commit into from
Jan 29, 2020

Conversation

phil-davis
Copy link
Contributor

No description provided.

@phil-davis phil-davis requested a review from staabm January 29, 2020 14:56
@phil-davis phil-davis self-assigned this Jan 29, 2020
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #494   +/-   ##
=========================================
  Coverage     98.68%   98.68%           
  Complexity     1757     1757           
=========================================
  Files            66       66           
  Lines          4271     4271           
=========================================
  Hits           4215     4215           
  Misses           56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b828a9...5fc446b. Read the comment docs.

@staabm
Copy link
Member

staabm commented Jan 29, 2020

just curious: did you do all this changes manually?

@staabm staabm merged commit 458bf94 into sabre-io:master Jan 29, 2020
@phil-davis
Copy link
Contributor Author

just curious: did you do all this changes manually?

There is a fixer for these: php_unit_no_expectation_annotation
https://github.com/FriendsOfPHP/PHP-CS-Fixer/

I had used it in owncloud/core#36501

Actually I forgot about the fixer until I already got halfway through cut-paste for this.

@phil-davis phil-davis deleted the use-phpunit8 branch January 30, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants