Skip to content

Commit

Permalink
explicitly cast content length to int (#79)
Browse files Browse the repository at this point in the history
  • Loading branch information
icewind1991 authored and staabm committed Aug 8, 2017
1 parent d5aa289 commit f0b27a6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/Sapi.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ static function sendResponse(ResponseInterface $response) {
if (is_resource($body) && get_resource_type($body) == 'stream') {
if (PHP_INT_SIZE !== 4){
// use the dedicated function on 64 Bit systems
stream_copy_to_stream($body, $output, $contentLength);
stream_copy_to_stream($body, $output, (int)$contentLength);
} else {
// workaround for 32 Bit systems to avoid stream_copy_to_stream

This comment has been minimized.

Copy link
@rmufr

rmufr Sep 25, 2018

Caution : Commit #74 breaks content range GETs support of iOs devices - especially it breaks html5 streaming video playback if the Dav server OS is 32bits.
Created issue #108

This comment has been minimized.

Copy link
@staabm

staabm Sep 25, 2018

Member

Note sure what this implies.

Could you create a issue and describe what the problem is and how to reproduce?

This comment has been minimized.

Copy link
@rmufr

rmufr Sep 26, 2018

Hi @staabm
My comment is attached to the wrong commit, sorry for that.
Anyway, I created the issue, #108 , regarding commit #74 .

while (!feof($body)) {
Expand Down

0 comments on commit f0b27a6

Please sign in to comment.