Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\Sabre\CalDAV\Schedule\Plugin::beforeUnbind calls \Sabre\DAVACL\IACL::getOwner without a type check #1345

Open
ChristophWurst opened this issue Jun 1, 2021 · 1 comment

Comments

@ChristophWurst
Copy link
Contributor

ChristophWurst commented Jun 1, 2021

$node->getOwner()

The node might not have ACLs implemented. In that case this calls a method that doesn't exist.

In my case it's an \Sabre\CalDAV\ICalendarObject that gets deleted. Those often have ACLs, but not always. It might make sense to exit early when IACL is not implemented by the node.

Moreover a null owner will lead to a type issue.

ChristophWurst added a commit to nextcloud/server that referenced this issue Jun 2, 2021
Due to a bug in Sabre it's necessary for calendar objects to implement
ACLs. Otherwise the scheduling plugin will throw an error when it tries
to fetch the owner of a calendar object that is being deleted.

Ref sabre-io/dav#1345

Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst added a commit to nextcloud/server that referenced this issue Jun 2, 2021
Due to a bug in Sabre it's necessary for calendar objects to implement
ACLs. Otherwise the scheduling plugin will throw an error when it tries
to fetch the owner of a calendar object that is being deleted.

Ref sabre-io/dav#1345

Signed-off-by: Christoph Wurst <[email protected]>
@DeepDiver1975
Copy link
Member

Hey @ChristophWurst 👋

Feel free to submit a PR to address this. THX a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants