Fix pe/follow-current-open when not in project buffer #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archenoth
force-pushed
the
master
branch
4 times, most recently
from
d1f6200 to
ec1a03d
Compare
|
+1, this is very useful. @sabof, do you care to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
pe/follow-currentis set tot, if you visit any buffer that is not in a project and you have projectile installed,pe/follow-current-opendisplays an error in the minibuffer every time the timer function is run...The error comes from Projectile when it is called with the default project root command on line 292 of project-explorer.el.
This pull request makes the timer function only try to follow the current project if we are in one.
The reason I changed
pe/follow-current-openand notpe/project-root-function-defaultis becausepe/follow-current-openappears to be the only location where this error isn't useful, and the projectile command can short-circut the logic in project-explorer so that it will be slightly more future-proof.