Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): resolution unified to v11, vfile to v6 #1163

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix(deps): resolution unified to v11, vfile to v6 #1163

merged 1 commit into from
Sep 25, 2023

Conversation

sabertazimi
Copy link
Owner

Pull Request

This PR Contains

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Test-Case

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Breaking Changes

Additional Info

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 4:13pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Lighthouse Report

https://blog-otvlbbov1-sabertaz.vercel.app/

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 95
🟢 accessibility 100
🟢 best-practices 92
🟢 seo 100
🟢 pwa 100

https://blog-otvlbbov1-sabertaz.vercel.app/posts

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 98
🟢 accessibility 92
🟢 best-practices 92
🟢 seo 100
🟢 pwa 100

https://blog-otvlbbov1-sabertaz.vercel.app/tags

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 99
🟢 accessibility 92
🟢 best-practices 92
🟢 seo 100
🟢 pwa 100

https://blog-otvlbbov1-sabertaz.vercel.app/books

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 99
🟢 accessibility 92
🟢 best-practices 92
🟢 seo 100
🟢 pwa 100

https://blog-otvlbbov1-sabertaz.vercel.app/about

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 98
🟢 accessibility 92
🟢 best-practices 92
🟢 seo 100
🟢 pwa 100

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f0b23bc) 98.49% compared to head (3b46392) 98.49%.

❗ Current head 3b46392 differs from pull request most recent head 3319845. Consider uploading reports for the commit 3319845 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1163   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files         176      176           
  Lines         866      866           
  Branches       86       86           
=======================================
  Hits          853      853           
  Misses         10       10           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-quantifier-deprecated

This PR has 5 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -1
Percentile : 2%

Total files changed: 2

Change summary by file extension:
.json : +4 -1
.lock : +0 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rehype-katex 6.0.3...7.0.0 None +15/-11 405 kB wooorm

@sabertazimi sabertazimi merged commit a1d6a90 into main Sep 25, 2023
@sabertazimi sabertazimi deleted the deps branch September 25, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant