fix(saber-plugin-image): remove blendIn class when image is loaded #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for saber ready! Built with commit 980d3e4 |
egoist
commented
Aug 28, 2019
|
LOL when I refactored the plugin I extracted the inline styles to stylesheet to prevent things like this but it seems |
|
This is just a temporary fix, if one zooms the image before load complete the bug still appears. We need francoischalifour/medium-zoom#110 to get addressed. I guess I will make a PR to them to inline their transition style. |
kidonng
reviewed
Aug 29, 2019
| loaded: el => { | ||
| el.addEventListener('load', () => { | ||
| el.setAttribute('data-lazy-loaded', '') | ||
| this.removeBlendIn = setTimeout(() => { |
There was a problem hiding this comment.
Ah, I didn't look at your code. Guess listening to transitionend is better?
There was a problem hiding this comment.
Yeah sure, I just went with the easiest way.
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
blendInclass makes medium-zoom stop workingWhat kind of change does this PR introduce? (check at least one)
If changing the UI/CSS related code, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)