[Upgrade Assistant] Set fix_logs step as incomplete if log collection…

… is not enabled (elastic#111827) * set step as incomplete if toggle is disabled * Fix test names * Remove unnecessary mocks
sabarasaba · Oct 26, 2021 · ed5e6e5 · ed5e6e5
1 parent 3581826
commit ed5e6e5
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 11 deletions.
diff --git a/...grade_assistant/__jest__/client_integration/overview/fix_logs_step/fix_logs_step.test.tsx b/...grade_assistant/__jest__/client_integration/overview/fix_logs_step/fix_logs_step.test.tsx
@@ -50,11 +50,7 @@ describe('Overview - Fix deprecation logs step', () => {
 
   describe('Step status', () => {
     test(`It's complete when there are no deprecation logs since last checkpoint`, async () => {
-      httpRequestsMockHelpers.setUpdateDeprecationLoggingResponse(getLoggingResponse(true));
-
-      httpRequestsMockHelpers.setLoadDeprecationLogsCountResponse({
-        count: 0,
-      });
+      httpRequestsMockHelpers.setLoadDeprecationLogsCountResponse({ count: 0 });
 
       await act(async () => {
         testBed = await setupOverviewPage();
@@ -68,20 +64,36 @@ describe('Overview - Fix deprecation logs step', () => {
     });
 
     test(`It's incomplete when there are deprecation logs since last checkpoint`, async () => {
-      httpRequestsMockHelpers.setUpdateDeprecationLoggingResponse(getLoggingResponse(true));
+      httpRequestsMockHelpers.setLoadDeprecationLogsCountResponse({ count: 5 });
 
-      httpRequestsMockHelpers.setLoadDeprecationLogsCountResponse({
-        count: 5,
+      await act(async () => {
+        testBed = await setupOverviewPage();
       });
 
+      const { exists, component } = testBed;
+
+      component.update();
+
+      expect(exists(`fixLogsStep-incomplete`)).toBe(true);
+    });
+
+    test(`It's incomplete when log collection is disabled `, async () => {
+      httpRequestsMockHelpers.setLoadDeprecationLogsCountResponse({ count: 0 });
+
       await act(async () => {
         testBed = await setupOverviewPage();
       });
 
-      const { exists, component } = testBed;
+      const { actions, exists, component } = testBed;
 
       component.update();
 
+      expect(exists(`fixLogsStep-complete`)).toBe(true);
+
+      httpRequestsMockHelpers.setUpdateDeprecationLoggingResponse(getLoggingResponse(false));
+
+      await actions.clickDeprecationToggle();
+
       expect(exists(`fixLogsStep-incomplete`)).toBe(true);
     });
   });

diff --git a/.../upgrade_assistant/public/application/components/overview/fix_logs_step/fix_logs_step.tsx b/.../upgrade_assistant/public/application/components/overview/fix_logs_step/fix_logs_step.tsx
@@ -61,6 +61,15 @@ const FixLogsStep: FunctionComponent<Props> = ({ setIsComplete }) => {
     saveLogsCheckpoint(checkpoint);
   }, [checkpoint]);
 
+  useEffect(() => {
+    if (!state.isDeprecationLogIndexingEnabled) {
+      setIsComplete(false);
+    }
+
+    // Depending upon setIsComplete would create an infinite loop.
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [state.isDeprecationLogIndexingEnabled]);
+
   return (
     <>
       <EuiText>

diff --git a/x-pack/plugins/upgrade_assistant/public/shared_imports.ts b/x-pack/plugins/upgrade_assistant/public/shared_imports.ts
@@ -18,8 +18,6 @@ export {
 
 export { Storage } from '../../../../src/plugins/kibana_utils/public';
 
-export { KibanaContextProvider } from '../../../../src/plugins/kibana_react/public';
-
 export { DataPublicPluginStart } from '../../../../src/plugins/data/public';
 
 export { APP_WRAPPER_CLASS } from '../../../../src/core/public';