Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Whitespace fix for editing text #26

Merged
merged 5 commits into from
Nov 8, 2024
Merged

[Fix] Whitespace fix for editing text #26

merged 5 commits into from
Nov 8, 2024

Conversation

00salmon
Copy link
Contributor

@00salmon 00salmon commented Nov 7, 2024

Description of the change

Bump versions of prosemirror packages

All whitespace was being trimmed from text in situations such as:
Test <strong>Text</strong> Here -> Test<strong>Text</strong>Here

  • removing the global whitespace cleanup fixes this case

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: f5ec32b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@raisins/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@00salmon 00salmon requested a review from Locrian24 November 8, 2024 19:10
Locrian24
Locrian24 previously approved these changes Nov 8, 2024
Copy link
Contributor

@Locrian24 Locrian24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍🏻

@00salmon 00salmon merged commit ca29df3 into main Nov 8, 2024
1 check passed
@00salmon 00salmon deleted the whitespace-fix branch November 8, 2024 19:26
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants