Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Allow examples with styled wrappers #24

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Conversation

00salmon
Copy link
Contributor

@00salmon 00salmon commented Oct 25, 2024

Description of the change

Examples with wrappers that were different than the component's tag name were not being grouped with the component they were defined in, this fix allows more advanced examples to be used within the raisins editor
pify added to devDependencies so changesets can run

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 011359f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@raisins/stencil-docs-target Patch
@raisins/schema Patch
@raisins/react Patch
@raisins/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@00salmon 00salmon requested a review from zachharrison October 29, 2024 18:33
@00salmon 00salmon merged commit c446297 into main Oct 29, 2024
1 check passed
@00salmon 00salmon deleted the example-group-fix branch October 29, 2024 18:44
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants