N5S3ZarrReader: combine N5ZarrReader logic into N5AmazonS3Reader subclass #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bclass Until there are interfaces, wrappers, or similar composable objects which allow having both S3 access and Zarr reading, the N5S3ZarrReader allows a client to explicitly choose the combination of both. This commit copies methods in order to having a working version of the reader. Future clean up includes extracting methods to a helper class, introducing abstract methods to reduce repeated code blocks, and similar. see: saalfeldlab/n5-aws-s3#10 (comment)
|
cc: @axtimwalde @tischi The unit test reading from IDR's S3 is working but the entire data volume has not yet been validated (e.g. viewed) in Java. |
|
Following |
|
FYI, I temporarily copy and pasted the whole code here: https://github.com/mobie/mobie-viewer-fiji/tree/s3zarr/src/main/java/de/embl/cba/mobie/n5/zarr Because that it was easier for me to develop code on top to read ome.zarr from s3 into BigDataViewer (BDV). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until there are interfaces, wrappers, or similar composable objects
which allow having both S3 access and Zarr reading, the N5S3ZarrReader
allows a client to explicitly choose the combination of both. This
commit copies methods in order to having a working version of the
reader. Future clean up includes extracting methods to a helper class,
introducing abstract methods to reduce repeated code blocks, and similar.
see: saalfeldlab/n5-aws-s3#10 (comment)