logging to DEBUG the source of configuration values (whether from POM or sysenv) #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please advise on how you would like to have it tested. Other than running |
|
For test you can use https://www.simplify4u.org/slf4j-mock/ and add simply assertions to existing tests |
mccartney
commented
Oct 14, 2021
Comment on lines
-256
to
-257
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-simple</artifactId> |
There was a problem hiding this comment.
If slf4j-simple was present it got in the way - i.e. the logger for PGPKeyInfo got set to SimpleLogger
|
PTAL @slawekjaranowski |
slawekjaranowski
requested changes
Oct 15, 2021
src/main/java/org/simplify4u/plugins/sign/openpgp/PGPKeyInfo.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
slawekjaranowski
approved these changes
Oct 16, 2021
|
@mccartney thanks |
|
@mccartney - if you wish you can add yourself to contributor list in pom.xml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #82.
i.e. logging to
DEBUGlevel a simple information on where did a specific configuration property came from - either from POM or the system environment variable.