Allow maven encryption for keyPass #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
mkarg
reviewed
Jan 22, 2021
| @@ -8,12 +8,15 @@ | |||
| Creates OpenPGP signatures for all of the project's artifacts | |||
| without any external software. | |||
|
|
|||
| This plugin can replace **maven-gpg-plugin** in easy way and give you new feature. | |||
There was a problem hiding this comment.
English Gramar, so it should be: "in an easy way and provide new features."
mkarg
reviewed
Jan 22, 2021
| @@ -67,6 +68,7 @@ protected static void verifyArtifact(Artifact artifact) { | |||
| * @param inputStream data to sign | |||
| * @param artifactId used for build filename | |||
| * @param classifier used for build filename | |||
| * @param version used for build filename | |||
There was a problem hiding this comment.
English Grammar: Either "used for built filename" or "used to build filename".
mkarg
reviewed
Jan 22, 2021
| @@ -4,10 +4,14 @@ Introduction | |||
| `Sign Maven Plugin` allows you to creates OpenPGP signatures for all of the project's artifacts | |||
| without any external software. | |||
|
|
|||
| # Feature | |||
| This plugin can replace **maven-gpg-plugin** in easy way and give you new feature. | |||
mkarg
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #33