WIP: [19] Assert signature file name syntax

[mkarg]

This is a first draft of a possible solution for issue #19.

What I am stuck with is how I can access the IT maven project instance from within the postbuild.groovy script? I need that to solve the following issues:

• SHOULD NOT hard code the version number in the script, as it would imply to change all scripts again and again for each new version of the project.
• SHOULD NOT hard code the expected file name as a literal, as it would imply to change the script again if more signature files are added to the existing IT test case.

Closes #19

[mkarg]

@slawekjaranowski I think my personal experience with Maven Invoker Plugin is not good enough to solve the two open questions on my own. Do you have an idea for me?

[slawekjaranowski]

• ITs project version is hardcoded in invoker.properties and it is independent of real project version
• we can have hardcode file names - I prefer more unit test then ITs running by maven-invoker, so I expect that we will not do many changes in it

[mkarg]

I'm driving nuts. Even if I put an additional -Drevision=1.1.1 in the invoker.mavenOpts line, still System.properties.'revision' always returns null (while it works with any other environment variable). Do you have a clue what my fault is?

[slawekjaranowski]

settings from invoker.properties are used for maven execution not for before/after script.
If you need new values in before/after script you should use scriptVariables configuration for maven-invoker plugin
https://maven.apache.org/plugins/maven-invoker-plugin/examples/post-build-script.html

[mkarg]

That does not solve the problem: The version number is then just moved from the script file to another file, but in any way it would be duplicated. So to sum up: Shall we simply hard-code the version number in the groovy script?

[slawekjaranowski]

yes we can hardcode version in groovy. We have only 4 ITs tests so will not huge work to change it if we need.

[mkarg]

Ok, in that case I am done with this draft and would kindly ask to review this PR. :-)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[slawekjaranowski]

After merging last two PR I will release new version.
If you wish please add yourself to developer list in pom.xml

[mkarg]

After merging last two PR I will release new version.
If you wish please add yourself to developer list in pom.xml

Please Review #24 - Thank you for inviting me into this project! It is fun working with you! :-)