Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size and count validation for AppendInput #61

Closed
shikhar opened this issue Nov 15, 2024 · 2 comments · Fixed by #72
Closed

Size and count validation for AppendInput #61

shikhar opened this issue Nov 15, 2024 · 2 comments · Fixed by #72
Assignees
@vrongmeal
Milestone
M1

Comments

@shikhar
Copy link
Member

shikhar commented Nov 15, 2024

When converting to api::AppendInput, validate that there are no more than 1000 records and 1MiB of metered size in total. Exceeding this would be rejected by the service, but there is no point making the request.
@shikhar shikhar added this to the M1 milestone Nov 15, 2024
@vrongmeal
Copy link
Member

Yup, that's reasonable.

vrongmeal added a commit that referenced this issue Nov 18, 2024
@vrongmeal
fix: Validate append input when converting from sdk type to api
1e4a89e 
Resolves: #61

Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal vrongmeal mentioned this issue Nov 18, 2024
Merged
@vrongmeal
Copy link
Member

Re-opening due to #65 (comment)

@vrongmeal vrongmeal reopened this Nov 18, 2024
vrongmeal added a commit that referenced this issue Nov 20, 2024
@vrongmeal
feat: Pre-validate append record batch
22a7613 
Resolves: #61

Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal vrongmeal mentioned this issue Nov 20, 2024
Merged
vrongmeal added a commit that referenced this issue Nov 20, 2024
@vrongmeal
feat: Pre-validate append record batch
925e5a6 
Resolves: #61

Signed-off-by: Vaibhav Rabber <[email protected]>
vrongmeal added a commit that referenced this issue Nov 20, 2024
@vrongmeal
feat: Pre-validate append record batch
bab5568 
Resolves: #61

Signed-off-by: Vaibhav Rabber <[email protected]>
vrongmeal added a commit that referenced this issue Nov 20, 2024
@vrongmeal
feat: Pre-validate append record batch
85792d4 
Resolves: #61

Signed-off-by: Vaibhav Rabber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrongmeal vrongmeal

Labels
None yet
Projects
None yet
Milestone
M1
Development

Successfully merging a pull request may close this issue.

feat: Pre-validate append record batch s2-streamstore/s2-sdk-rust
2 participants
@shikhar @vrongmeal