-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add commands for command records #33
Comments
@vrongmeal also think about how to display command records when reading, maybe stderr-only? a |
@shikhar by If yes, we can simply have:
Similar to I was also thinking if we have a way to add headers to an append record. Maybe multiple "header" command messages followed by the actual message.
The above would evaluate as:
|
Didn't catch this. When do we want to display a command record? |
Ah no, I had meant these would be stream-level commands that result in a unary I don't want to be further interpreting the newline-delimited plaintext data we currently support. We do need to consider alternate formats that allow encoding headers as well as binary data, but let's do that separately. |
Command records have binary payloads - so we can't display them with the current interpretation |
Resolves: #33 Signed-off-by: Vaibhav Rabber <[email protected]>
Acts on a stream, I reckon something like...
.. trim <trim-point>
.. fence <token>
SDK exposes a
CommandRecord
type, this would utilize that to prepare a record to appendThe text was updated successfully, but these errors were encountered: