Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TargetArn as valid destination for publish #47

Merged
merged 2 commits into from
May 10, 2018
Merged

add TargetArn as valid destination for publish #47

merged 2 commits into from
May 10, 2018

Conversation

janjaali
Copy link
Contributor

@janjaali janjaali commented May 8, 2018

Addressed issue: #46

This PR adds targetArn besides to topicArn as additional valid destination-field to publish messages to the SNS.

@codecov-io
Copy link

codecov-io commented May 8, 2018

Codecov Report

Merging #47 into master will increase coverage by 0.04%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   40.47%   40.52%   +0.04%     
==========================================
  Files          22       22              
  Lines         420      422       +2     
  Branches       13       13              
==========================================
+ Hits          170      171       +1     
- Misses        250      251       +1
Impacted Files Coverage Δ
src/main/scala/me/snov/sns/api/PublishApi.scala 72.22% <75%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003ce56...872ea60. Read the comment docs.

@s12v s12v merged commit ba52c4a into s12v:master May 10, 2018
@s12v
Copy link
Owner

s12v commented May 10, 2018

thank you, @janjaali

@s12v s12v mentioned this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants