add a test

s12v · Dec 9, 2018 · 542ec8f · 542ec8f
1 parent 895fa47
commit 542ec8f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/provider/awsssm/awsssm.go b/provider/awsssm/awsssm.go
@@ -45,9 +45,8 @@ func (p *SsmProvider) Decode(val string) (string, error) {
 	name := val[len(prefix):]
 	var withEncryption = true
 	input := &ssm.GetParameterInput{Name: &name, WithDecryption: &withEncryption}
-	fmt.Printf("name: %v\n", name)
 	if err := input.Validate(); err != nil {
-		return val, nil
+		return val, err
 	}
 
 	if output, err := fetch(p.awsSSmClient, input); err != nil {

diff --git a/provider/awsssm/awsssm_test.go b/provider/awsssm/awsssm_test.go
@@ -35,3 +35,10 @@ func TestSsmProvider_Decode(t *testing.T) {
 		t.Fatalf("unexpected plaintext %v", r)
 	}
 }
+
+func TestSsmProvider_DecodeInvalidInput(t *testing.T) {
+	ssmProvider := SsmProvider{}
+	if r, err := ssmProvider.Decode("{aws-ssm}"); err == nil {
+		t.Fatal("expected an error", r)
+	}
+}