Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Fixes #811
I'm opening this PR as an attempt to resolve
jest
+testing-library
issue reported in #811.I have an open question on that issue #811 (comment) where I wondered why
el.selectionStart !== el.selectionEnd
existed; but after a lot of thinking I cannot see a reason for itMy thinking
selectionStart
andselectionEnd
will always be the same when the caret is placed and nothing is selected:Screen.Recording.2023-11-21.at.9.32.13.PM.mov
so
el.selectionStart !== el.selectionEnd
will only happen if the user have text selected:Screen.Recording.2023-11-21.at.9.32.38.PM.mov
which differs from the intention described by the inline comment that is in the code:
But please let me know if I've missed something else on my analysis 🙏