Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep original type specifiers around #30

Open
Bike opened this issue Jun 25, 2024 · 0 comments
Open

Keep original type specifiers around #30

Bike opened this issue Jun 25, 2024 · 0 comments
Assignees
@Bike
Labels
enhancement New feature or request

Comments

@Bike
Copy link
Member

Bike commented Jun 25, 2024

The unparse methods have gotten very unwieldy in a probably vain attempt to print ctypes nicely. We could just keep the original type specifiers around when ctypes are constructed from specifiers, and print those. It would be a little memory overhead but shouldn't be a big deal. We'll need to keep the unparse methods for when ctypes are constructed by other more synthetic means (e.g. disjoin or just make-instance-ing the classes directly).
@Bike Bike added the enhancement New feature or request label Jun 25, 2024
@Bike Bike self-assigned this Jun 25, 2024
Bike added a commit that referenced this issue Jun 26, 2024
@Bike
Save specifiers for nicer printing (#30)
8af5ce4
Bike added a commit that referenced this issue Jun 30, 2024
@Bike
Delete obsolete part of disjunction unparser
a3ea005 
+floats+ no longer exists and I don't want to make this client
dependent still, so I'll just axe this. With #30 unparse is less
important, anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bike Bike

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bike