Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report correct location for parse error diagnostics (Language Server) #176

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

fizruk
Copy link
Member

@fizruk fizruk commented Apr 2, 2024

Some hacks to report properly location of parse errors (instead of at the start of the file):

  • Happy parse errors
  • Happy parse errors (due to lexer)
  • BNFC layout resolver errors

Examples:

Screenshot 2024-04-02 at 16 13 21 Screenshot 2024-04-02 at 16 14 22 Screenshot 2024-04-02 at 16 15 10 Screenshot 2024-04-02 at 16 15 56

@fizruk fizruk changed the title Report correct location for parse error diagnostics Report correct location for parse error diagnostics (Language Server) Apr 2, 2024
@fizruk fizruk merged commit d522791 into develop Apr 2, 2024
6 checks passed
@fizruk fizruk deleted the better-parse-error-diagnostics branch April 2, 2024 13:28
@fizruk fizruk mentioned this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant