Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update haskell dependencies (Nix) #126

Closed
wants to merge 21 commits into from
Closed

Update haskell dependencies (Nix) #126

wants to merge 21 commits into from

Conversation

deemp
Copy link
Contributor

@deemp deemp commented Oct 3, 2023

  • Updated:
    • haskell-language-server: 2.1.0.0 -> 2.3.0.0
    • hpack: 0.35.2 -> 0.36.0
    • fourmolu: 0.13.1.0 -> 0.14.0
  • Added a script to push flake outputs to cachix
    • There were multiple cache misses during builds of these tools. I'd like to cache them so that contributors can take them from cache.
    • Depends on Create a cachix cache #127

@deemp deemp changed the title Update haskell dependencies in Nix Update haskell dependencies (Nix) Oct 3, 2023
@deemp deemp mentioned this pull request Oct 3, 2023
@deemp deemp marked this pull request as draft October 6, 2023 21:30
@deemp deemp marked this pull request as ready for review October 6, 2023 21:37
.github/workflows/ghcjs.yml Outdated Show resolved Hide resolved
@deemp deemp marked this pull request as draft October 8, 2023 18:20
@deemp
Copy link
Contributor Author

deemp commented Oct 8, 2023

I'd like to check it with my cache.

.github/workflows/ghcjs.yml Outdated Show resolved Hide resolved
@fizruk
Copy link
Member

fizruk commented Oct 8, 2023

Do we want to also use this cachix cache for the builds?

@deemp
Copy link
Contributor Author

deemp commented Oct 8, 2023

Do we want to also use this cachix cache for the builds?

I think we can use this cache as a substituter in the ghcjs action.

We can have another action that caches all flake outputs to cachix.

restore-keys: |
${{ runner.os }}-nix-${{ hashfiles('./flake.nix', './flake.lock', '.github/workflows/ghcjs.yml', './rzk/rzk.cabal') }}
${{ runner.os }}-playground-ghcjs-
${{ runner.os }}-nix-
Copy link
Contributor Author

@deemp deemp Oct 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this -nix- restore key for now to populate new cache.

@deemp
Copy link
Contributor Author

deemp commented Oct 8, 2023

Okay, it worked with my cache.

image

@deemp
Copy link
Contributor Author

deemp commented Oct 8, 2023

The smaller rzk-0.6.6 is a static executable, I guess.

@deemp deemp closed this by deleting the head repository Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants