Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scishare coffee maker (scishare.coffee.s1102) #858

Merged
merged 3 commits into from
Feb 7, 2021

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Nov 9, 2020

First steps to implement and close #833

TBD:

  • Status codes are unknown
  • Tests

@matteos1
Copy link

as soon as possible i test the Scishare coffee maker

@matteos1
Copy link

There are some news? Is implemented in 0.118? Thank you

@syssi
Copy link
Collaborator

syssi commented Nov 18, 2020

@matteos1 Did you test this implementation?

@matteos1
Copy link

matteos1 commented Nov 18, 2020

@syssi i have tested and it seems to work.

@matteos1
Copy link

@syssi to test the file inside the custom component, I create a xiaomi_scishare folder, and insert init.py and scishare_coffeemaker.py (d188100)? what is the name of the platform to insert in the configuration.yaml, naturally with the attributes name, host, token?

@matteos1
Copy link

is it possible now to make scishare work with home hassistant?

@rytilahti
Copy link
Owner Author

Yes, it is possible but will require someone to do the integration. Also, at the moment it's still under discussion how "cookers" are to be exposed to homeassistant: home-assistant/architecture#501 .

@rytilahti rytilahti force-pushed the feature/scishare_coffee branch from ce4926c to ab58d5b Compare February 7, 2021 17:02
@rytilahti rytilahti merged commit 83841cf into master Feb 7, 2021
@rytilahti rytilahti deleted the feature/scishare_coffee branch February 7, 2021 18:13
@rytilahti rytilahti mentioned this pull request Mar 13, 2021
@khmelevskikh
Copy link

khmelevskikh commented Mar 19, 2021

Hi guys,
Commands with params doesn't work for me by some reason:

boil_water 300 90
Boiling 300 ml water (90C)
False

Raw command for the same works fine

@rytilahti
Copy link
Owner Author

@khmelevskikh could you please open an issue for that, and potentially include the commands you tried (with --debug to get the raw payloads)? Sounds like there is issue with the type conversion somewhere.

xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
…hti#858)

* Add support for Scishare coffee maker (scishare.coffee.s1102)

* Add some status codes, fix linting

* Fix incorrect unknown status code reporting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for xiaomi scishare coffee machine
4 participants