Make netifaces optional dependency (#970)

rytilahti · Mar 13, 2021 · ab70c70 · ab70c70
1 parent cf64f8f
commit ab70c70
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/miio/updater.py b/miio/updater.py
@@ -3,8 +3,6 @@
 from http.server import BaseHTTPRequestHandler, HTTPServer
 from os.path import basename
 
-import netifaces
-
 _LOGGER = logging.getLogger(__name__)
 
 
@@ -60,6 +58,14 @@ def __init__(self, file, interface=None):
 
     @staticmethod
     def find_local_ip():
+        try:
+            import netifaces
+        except Exception:
+            _LOGGER.error(
+                "Unable to import netifaces, please install netifaces library"
+            )
+            raise
+
         ifaces_without_lo = [
             x for x in netifaces.interfaces() if not x.startswith("lo")
         ]

diff --git a/pyproject.toml b/pyproject.toml
@@ -30,7 +30,7 @@ attrs = "*"
 pytz = "*"
 appdirs = "^1"
 tqdm = "^4"
-netifaces = "^0"
+netifaces = { version = "^0", optional = true }
 android_backup = { version = "^0", optional = true }
 importlib_metadata = { version = "^1", markers = "python_version <= '3.7'" }
 croniter = "^0"