Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go1.13 build fix: go.mod: go1.12 => go1.13 #68

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Conversation

savalin
Copy link
Contributor

@savalin savalin commented Feb 10, 2020

Using go1.13.7 for building my project (that uses github.com/y0ssar1an/q as a dependency) I got the error:

github.com/y0ssar1an/[email protected] requires
github.com/golangci/[email protected] requires
github.com/golangci/[email protected]: invalid version: unknown revision 2cefd77fef9b

I've cloned the repository, made local changes in go.mod (just set up go1.13)

index 86f936a..092e9a3 100644
--- a/go.mod
+++ b/go.mod
@@ -1,5 +1,5 @@
 module github.com/y0ssar1an/q

-go 1.12
+go 1.13

 require github.com/kr/pretty v0.2.0
(END)

used the 'replace' in my project's go.mod (from github.com/y0ssar1an/q to local copy) - and that helped.

At the same time, it works without any go.mod changes when I used go1.12.13 for the project build.
Also, after making these go.mod changes I stay able to build the project using go1.12.

It seems it could be better to use go1.13 in master to avoid problems like this one.

@savalin savalin changed the title Issue #67 fix: go.mod: go1.12 => go1.13 Go1.13 build fix: go.mod: go1.12 => go1.13 Feb 10, 2020
@savalin savalin requested a review from ryboe February 10, 2020 14:32
@ryboe
Copy link
Owner

ryboe commented Feb 10, 2020

First, thank you very much for the PR!

github.com/y0ssar1an/[email protected] requires
github.com/golangci/[email protected] requires

Hmm, that's very strange. v1.0.8 shouldn't have any dependency on golangci-lint. This must be some modules weirdness that I don't understand. I know there were changes modules behavior from 1.12 -> 1.13.

Even though we don't have a root cause, I still want to merge this. Go 1.14 is about to land, and I only want to support the last two releases of the compiler. Thanks again for providing this fix!

@ryboe ryboe merged commit b845c29 into ryboe:master Feb 10, 2020
@ryboe
Copy link
Owner

ryboe commented Feb 10, 2020

I released v1.0.9, which contains this fix. I hope bumping the version solves your problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants