Skip to content

Commit

Permalink
Unconditionally build zdb and ztest with -DDEBUG
Browse files Browse the repository at this point in the history
Illumos unconditionally builds zdb and ztest with -DDEBUG. This helps
catch bugs and eliminates the need for commits like
2026196, which changed ASSERTs to
VERIFYs. The following files in the illumos tree show this:

usr/src/cmd/zdb/Makefile.com
usr/src/cmd/ztest/Makefile.com

Given the usefulness of having early failure in these tools, we should
do it too.

Signed-off-by: Richard Yao <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#4095
  • Loading branch information
ryao authored and behlendorf committed Dec 14, 2015
1 parent 245b7ab commit 2707511
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cmd/zdb/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
include $(top_srcdir)/config/Rules.am

AM_CPPFLAGS += -DDEBUG

DEFAULT_INCLUDES += \
-I$(top_srcdir)/include \
-I$(top_srcdir)/lib/libspl/include
Expand Down
1 change: 1 addition & 0 deletions cmd/ztest/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
include $(top_srcdir)/config/Rules.am

AM_CFLAGS += $(DEBUG_STACKFLAGS) $(FRAME_LARGER_THAN)
AM_CPPFLAGS += -DDEBUG

DEFAULT_INCLUDES += \
-I$(top_srcdir)/include \
Expand Down

0 comments on commit 2707511

Please sign in to comment.