Remove update DNS functions #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the "update" functions for CNAME and A records. The Pi-hole API does not formally support updates, just list, create, delete. Update was implemented here by combining create and delete, which is not atomic but would be assumed to be so if you didn't inspect the code. Instead of creating/deleting under the hood which wasn't a great idea in the first place, we can have Terraform do this for us by forcing replacement on cname.target and dns.ip. This way the implications of the proposed changes are clearly stated by the Terraform plan, instead of hiding the behavior behind a function.