Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#44) media 3 exoplayer bug android 14 #76

Merged
merged 7 commits into from
Jul 13, 2024

Conversation

ryanw-mobile
Copy link
Owner

Finally Google released the bug fix, so there is no code change at our side to fix the playback scaling issues.
Tested works.

* main: (39 commits)
  [chore] Codacy: add Codacy check and badge
  [chore] Renovate: Update agp 8.4.2 to v8.5.0
  [chore] Renovate: Update dependency androidx.compose:compose-bom 2024.05.00 to v2024.06.00
  [chore] Renovate: Update androidx-lifecycle 2.7.0 to v2.8.2
  [chore] Renovate: Update agp 8.4.1 to v8.4.2
  [chore] Renovate: Update dependency org.jetbrains.kotlinx.kover 0.8.0 to v0.8.1
  [chore] Renovate: Update dependency io.kotest:kotest-assertions-core 5.9.0 to v5.9.1
  [chore] Renovate: Update dependency com.google.devtools.ksp 2.0.0-1.0.21 to v2.0.0-1.0.22
  [docs] README.md: update dependency list
  [chore] Renovate: add rules to block lifecycle upgrades
  [chore] Gradle: Kotlin/Compose Compiler 2.0 migration
  [chore] Renovate: Update kotlin
  [chore] Renovate: Update dependency gradle 8.7 to v8.8
  [chore] kover: fix migration error
  [chore] Renovate: Update dependency org.jetbrains.kotlinx.kover 0.7.6 to v0.8.0
  [chore] Renovate: Update kotlin
  [chore] Renovate: Update lifecycle 2.7.0 to v2.8.1
  [chore] Renovate: Update agp 8.4.0 to v8.4.1
  [chore] Renovate: Update dependency org.robolectric:robolectric 4.12.1 to v4.12.2
  Revert "[chore] Renovate: Update lifecycle 2.7.0 to v2.8.0"
  ...
* main:
  [chore] Renovate: Update agp 8.5.0 to v8.5.1
  [chore] Renovate: Update dependency com.google.devtools.ksp 2.0.0-1.0.22 to v2.0.0-1.0.23
  [chore] Renovate: Update dependency gradle 8.8 to v8.9
  [chore] Renovate: Update dependency org.robolectric:robolectric 4.12.2 to v4.13
  [chore] Renovate: Update androidx-lifecycle 2.8.2 to v2.8.3
  [docs] README.md: update media3 bug status
  [chore] Renovate: Update dependency org.jetbrains.kotlinx.kover 0.8.1 to v0.8.2
  [chore] Renovate: Update dependency androidx.test:rules 1.6.0 to v1.6.1
  [chore] Renovate: Update dependency androidx.test:core-ktx 1.6.0 to v1.6.1
  [chore] Renovate: Update dependency androidx.test.ext:junit 1.2.0 to v1.2.1
  [chore] Renovate: Update dependency androidx.test.espresso:espresso-core 3.6.0 to v3.6.1
  [chore] Renovate: Update dependency androidx.test:rules 1.5.0 to v1.6.0
  [chore] Renovate: Update dependency androidx.test:core-ktx 1.5.0 to v1.6.0
  [chore] Renovate: Update dependency androidx.test.ext:junit 1.1.5 to v1.2.0
  [chore] Renovate: Update dependency androidx.test.espresso:espresso-core 3.5.1 to v3.6.0
@ryanw-mobile ryanw-mobile added the fix A bug fix for the user, not a fix to a build script. label Jul 13, 2024
@ryanw-mobile ryanw-mobile requested a review from rwmobi July 13, 2024 02:39
@ryanw-mobile ryanw-mobile self-assigned this Jul 13, 2024
@ryanw-mobile ryanw-mobile linked an issue Jul 13, 2024 that may be closed by this pull request
@ryanw-mobile ryanw-mobile enabled auto-merge July 13, 2024 02:39
rwmobi
rwmobi previously approved these changes Jul 13, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d799306) 342 318 92.98%
Head commit (61c8322) 342 (+0) 318 (+0) 92.98% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#76) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (d799306) to head (61c8322).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   89.29%   89.29%           
=======================================
  Files          20       20           
  Lines         327      327           
  Branches       25       25           
=======================================
  Hits          292      292           
  Misses         24       24           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanw-mobile ryanw-mobile merged commit c1dffa3 into main Jul 13, 2024
7 checks passed
@ryanw-mobile ryanw-mobile deleted the fix/44-media-3-exoplayer-bug-android-14 branch July 13, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix for the user, not a fix to a build script.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media 3 Exoplayer bug fix (Android 14 / API 34)
2 participants