Refactor, unit tests, bug fixes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: - Updated imports - Updated types - Fixed some bugs in tests Modification: - Updated imports - Updated types - Fixed some bugs in tests Result: - Improved typing - LSP not getting errors for imports in tests - Tests pass Testing: - `poetry run pytest -vs`
Motivation: - when trying to equip items it was not working Modification: - modified equip action - also improved player_input to return command and arguments Result: - equip now works as expected - can equip items with just 'e' and then wait for next prompt or add an argument with item name with 'e' Testing: - poetry run pytest -vs
Motivation: - Unit tests helped fixed some bugs Modification: - Some bugs with inventory and to equip items - made some things more readable Result: - Additional unit tests - Improved readablity Testing: - poetry run pytest -vs - poetry run black_star
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor, unit tests, bug fixes