Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the login status check statement from the search_train function. #238

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Remove the login status check statement from the search_train function. #238

merged 2 commits into from
Aug 2, 2023

Conversation

Nitro1231
Copy link
Contributor

#237 (comment)

위 이슈에서 언급한 것처럼, 기존 srt.py 스크립트의 search_train 함수에서 불필요하게 사용자의 로그인 여부를 확인하던 부분을 제거했습니다.

ryanking13
ryanking13 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Owner

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다. changelog 파일 업데이트를 해주시겠어요?

@Nitro1231
Copy link
Contributor Author

Unreleased로 하면 될까요 아님 버전표기도 v2.0.8로 올릴까요?
혹여 버전을 올리게 된다면 SRT/__init__.py 에 있는 __version__ 말고 수정해야할 다른 부분도 있을까요?

@ryanking13
Copy link
Owner

Unreleased에 추가해주시면 제가 version bump를 하도록 하겠습니다.

@Nitro1231
Copy link
Contributor Author

업데이트 했습니다!

@ryanking13 ryanking13 merged commit 8b0e4cf into ryanking13:master Aug 2, 2023
@ryanking13 ryanking13 mentioned this pull request Aug 2, 2023
Closed
@ryanking13
Copy link
Owner

v2.0.8로 릴리즈 하였습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanking13 ryanking13 ryanking13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nitro1231 @ryanking13