add working implementation of 1D and nD potential landscape computation

[kushaangupta]

Closes #27

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[ryanharvey1]

See comments on static typing.

Add some type of test for potential_landscape and potential_landscape_nd

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

lolaBerkowitz commented on 2024-11-23T00:20:08Z
----------------------------------------------------------------

Format the entire notebook Black

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

lolaBerkowitz commented on 2024-11-23T00:20:09Z
----------------------------------------------------------------

Add language to describe the purpose of this section. For example, I'm looking at the plots and not knowing what I'm supposed to take from them. Is the fit in subplot (axis 2) good because it's shape matches the potential landscape? Include inferences/take-aways for each plot.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

lolaBerkowitz commented on 2024-11-23T00:20:10Z
----------------------------------------------------------------

Add inferences/take-aways to make the purpose of this section more clear

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

lolaBerkowitz commented on 2024-11-23T00:20:11Z
----------------------------------------------------------------

Why is ntrials so high (doesn't seem feasible for most data)? Can you reference influence of parameter values.

[lolaBerkowitz]

Make sure everything is formatted in Black. For the notebook, the figures look amazing but please add some descriptions/inferences to all sections. What is the purpose, what is the take home etc.