Skip to content

Commit

Permalink
Revert uglify-js version due to bad outputs.
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanelian committed Sep 19, 2018
1 parent 9e68c70 commit a16a575
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
1 change: 1 addition & 0 deletions bin/TypeScriptBuildWebpackPlugin.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"source-map": "0.7.3",
"tslint": "5.11.0",
"typescript": "3.1.0-rc.20180911",
"uglify-js": "3.4.9",
"uglify-js": "3.4.8",
"upath": "1.1.0",
"vue-loader": "15.4.2",
"vue-template-compiler": "2.5.17",
Expand All @@ -97,6 +97,7 @@
"ava": "1.0.0-beta.8"
},
"resolutions": {
"**/@types/node": "8"
"**/@types/node": "8",
"**/uglify-js": "3.4.8"
}
}
2 changes: 2 additions & 0 deletions src/TypeScriptBuildWebpackPlugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ function minifyChunkAssets(compilation: webpack.compilation.Compilation, chunks:
compilation.assets[fileName] = output;
}).catch(minifyError => {
Shout.error(`when minifying ${chalk.blue(fileName)} during JS build:`, minifyError);
Shout.warning('Only', chalk.yellow('ES5'), 'modules are suppported. Check',
chalk.cyan('tsconfig.json:target'), 'or', chalk.cyan('package.json'), 'dependencies.');
compilation.errors.push(minifyError);
});

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5461,10 +5461,10 @@ uglify-es@^3.3.4:
commander "~2.13.0"
source-map "~0.6.1"

[email protected].9, [email protected]:
version "3.4.9"
resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.4.9.tgz#af02f180c1207d76432e473ed24a28f4a782bae3"
integrity sha512-8CJsbKOtEbnJsTyv6LE6m6ZKniqMiFWmm9sRbopbkGs3gMPPfd3Fh8iIA4Ykv5MgaTbqHr4BaoGLJLZNhsrW1Q==
[email protected].8, [email protected]:
version "3.4.8"
resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.4.8.tgz#d590777b208258b54131b1ae45bc9d3f68033a3e"
integrity sha512-WatYTD84gP/867bELqI2F/2xC9PQBETn/L+7RGq9MQOA/7yFBNvY1UwXqvtILeE6n0ITwBXxp34M0/o70dzj6A==
dependencies:
commander "~2.17.1"
source-map "~0.6.1"
Expand Down

0 comments on commit a16a575

Please sign in to comment.