Fix sequence import just for review, this wont be merged #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtzero
force-pushed
the
fix-sequence-import
branch
from
39c817e to
13d8e39
Compare
jtrtj
approved these changes
Aug 19, 2021
jtzero
force-pushed
the
fix-sequence-import
branch
from
13d8e39 to
eafd113
Compare
jtrtj
force-pushed
the
fix-sequence-import
branch
2 times, most recently
from
6950621 to
78e07ca
Compare
jtzero
force-pushed
the
fix-sequence-import
branch
from
ef1c0fd to
d8533bc
Compare
jtzero
changed the title
jtzero
force-pushed
the
fix-sequence-import
branch
from
d8533bc to
2962e6b
Compare
|
Integration tests failure for 2962e6b0083e322b5c0872ed169ca43ae64fc566 |
jtzero
force-pushed
the
fix-sequence-import
branch
2 times, most recently
from
41050f7 to
656f775
Compare
dfedde
reviewed
Sep 7, 2021
pkg/resources/sequence.go
Outdated
| @@ -40,11 +41,13 @@ var sequenceSchema = map[string]*schema.Schema{ | |||
| Type: schema.TypeString, | |||
| Required: true, | |||
| Description: "The database in which to create the sequence. Don't use the | character.", | |||
| ForceNew: true, | |||
There was a problem hiding this comment.
these force news will cause the sequence count(next val) to reset when these are updated. is that expected/wanted?
There was a problem hiding this comment.
yes for a new database or schema it follows the same path that other tf-snowflake resources follow
There was a problem hiding this comment.
actually it won't reset it, but it will rebuild it with the original value
nextValue, err := strconv.Atoi(sequence.NextValue.String)
if err != nil {
return err
}
sq.WithStart(nextValue)
db3350d to
937058f
Compare
jtzero
force-pushed
the
fix-sequence-import
branch
from
937058f to
3163818
Compare
jtzero
force-pushed
the
fix-sequence-import
branch
from
3163818 to
97f515a
Compare
jtzero
force-pushed
the
fix-sequence-import
branch
from
97f515a to
75fe0d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is what will be pushed upstream
the release for our purposes is here #4
first #2Test Plan
References