Fix a bug when an exception occurs in a before all block #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-manges
commented
Jan 24, 2023
| @@ -87,9 +87,10 @@ def run_with_abq(reporter) | |||
| # be sent to us from ABQ, we now loop over all the examples, and mark | |||
| # every one that we must run in this group as a failure. | |||
| for_filtered_examples(reporter) do |example| | |||
| next unless Abq.target_test_case.is_example?(example) | |||
|
|
|||
| example.fail_with_exception(abq_reporter, ex) | |||
There was a problem hiding this comment.
There were two issues here:
abq_reporterwas undefined- we were looping over all of the examples but only marking the one currently assigned to the worker as failed. This causes a problem if the worker pulls another spec in the example group, but we've already moved past that in iterating over the tests
doxavore
force-pushed
the
dan/fix-before-all-exception
branch
2 times, most recently
from
b466cfd to
3a927ef
Compare
dan-manges
commented
Jan 24, 2023
spec/fixture_specs/raising_specs.rb
Outdated
|
|
||
| it 'fails' do | ||
| # should fail without running because of the exception in the after(:all) | ||
| exit 9999 |
There was a problem hiding this comment.
I know you're still working on this, but I wanted to mention that I intended this comment and exit 9999 to indicate "this code should never run" for the before(:all) case. This probably doesn't make sense for an after(:all) test.
doxavore
force-pushed
the
dan/fix-before-all-exception
branch
4 times, most recently
from
defef5e to
3cfc69d
Compare
doxavore
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.