Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for ruby 2.6 #106

Merged
merged 2 commits into from
Feb 15, 2023
Merged

drop support for ruby 2.6 #106

merged 2 commits into from
Feb 15, 2023

Conversation

michaelglass
Copy link
Contributor

@michaelglass michaelglass commented Feb 15, 2023 •
edited
Loading

resolves #105

@michaelglass michaelglass marked this pull request as ready for review February 15, 2023 13:15
michaelglass
michaelglass commented Feb 15, 2023
View reviewed changes
lib/rspec/abq/version.rb
@@ -1,6 +1,6 @@
module RSpec
module Abq
# current version!
VERSION = "1.1.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually a breaking change. Should we observe semver and bump to 2.0.0? We've been avoiding it because there have been a number of breaking changes. Also we don't really observe semver anywhere yet.

... but if not semver, what do the three numbers represent? kind of whim. I'd call this a minor [breaking] change because it shouldn't change anything for anybody else.

@michaelglass michaelglass merged commit eba1f09 into main Feb 15, 2023
@michaelglass michaelglass deleted the drop-ruby-2.6-support branch February 15, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-manges dan-manges dan-manges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Ruby 2.6
2 participants
@michaelglass @dan-manges