adapter.http: implement the attachment routes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhsjdhjs
suggested changes
Apr 4, 2024
There was a problem hiding this comment.
Most of my comments are just "use get_response_type()", so it should be easily implemented. While Response() it the correct type to use when returning values of Blob elements with the appropriate content_type, get_response_type() should be used in all other cases, as it automatically determines whether the client prefers a JSON or an XML response (e.g. for error messages).
Furthermore, you should use the "Return Early" pattern whenever possible. As already stated in several comments, I think the attachment routes shouldn't support File objects for now, at least not with unsanitized paths.
76 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.