Include map count in desync info #483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may be a bit of a niche use case, but some desyncs happen only (or a lot more frequently) when players are looking at different maps. Making a list of "which map was each player looking at" would be much more difficult to implement, but just having the map count can suggest if an issue could have possibly happened due to having multiple active maps or not. I've added a bit of extra safety (instead of `Find.Maps?.Count`) as I've encountered a couple of weird situations in the past where `Find.Maps.Count` ended up throwing `NullReferenceException`. This may have been a weird mod conflict/interaction, but I've decided to be on the safer side here.
SokyranTheDragon
added
low priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be a bit of a niche use case, but some desyncs happen only (or a lot more frequently) when players are looking at different maps. Making a list of "which map was each player looking at" would be much more difficult to implement, but just having the map count can suggest if an issue could have possibly happened due to having multiple active maps or not.
I've added a bit of extra null safety (instead of just using
Find.Maps.Count) as I've encountered a couple of weird situations in the past whereFind.Maps.Countended up throwingNullReferenceException. This may have been a weird mod conflict/interaction, but I've decided to be on the safer side here.