Fix errors caused by pocket maps with Multifaction/spectator faction #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FactionRepeater` ends up repeating `Storyteller.StorytellerTick` for all factions (including spectator, even with Multifaction off). The issue happens due to `StorytellerUtility.DefaultThreatPointsNow` using `Find.AnyPlayerHomeMap` if the target is a pocket map, which for factions without a home map will return null and cause `NullReferenceException`.
SokyranTheDragon
added
fix
|
Looking a bit deeper, it seems there may be some bigger issue at play here. I've seen a couple of more errors that happened due to spectator faction (multifaction off). Would need more investigation. |
|
Is my log the same as this bug? This issue has occurred 100+ times. |
Unrelated. |
|
Could this be what is causing the double quests to spawn? If the storyteller is ticking for both the player and the spectator at the same time, and then try to generate a quest for both, would it be possible that it just spawns 2 quests for the player faction? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FactionRepeaterends up repeatingStoryteller.StorytellerTickfor all factions (including spectator, even with Multifaction off). This causes issue due toStorytellerUtility.DefaultThreatPointsNowusingFind.AnyPlayerHomeMapif the target is a pocket map, which for factions without a home map will return null and causeNullReferenceException.