Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VFEcore desync when opening pregnancy approach float menu #398

Closed
rmarkus231 opened this issue Jan 1, 2024 · 2 comments
Closed

VFEcore desync when opening pregnancy approach float menu #398

rmarkus231 opened this issue Jan 1, 2024 · 2 comments

Comments

@rmarkus231
Copy link

Multiplayer: Error writing type: Verse.FloatMenuOption, obj: FloatMenuOption(Normal (pregnancy chance x100%), enabled), obj type: Verse.FloatMenuOption 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Exception filling tab RimWorld.ITab_Pawn_Social: Multiplayer.Client.SerializationException: No writer for type Verse.FloatMenuOption
  at Multiplayer.Client.SyncSerialization.WriteSyncObject (Multiplayer.Common.ByteWriter data, System.Object obj, Multiplayer.API.SyncType syncType) [0x00764] in <eeab71685d9f4a769b786d9dc34b45cf>:0 
  at Multiplayer.Client.SyncMethod+<>c__DisplayClass17_0.<DoSync>g__SyncObj|0 (System.Object obj, Multiplayer.API.SyncType type, System.String debugInfo) [0x00011] in <eeab71685d9f4a769b786d9dc34b45cf>:0 
  at Multiplayer.Client.SyncMethod.DoSync (System.Object target, System.Object[] args) [0x00114] in <eeab71685d9f4a769b786d9dc34b45cf>:0 
  at Multiplayer.Client.SyncTemplates.General (System.Int32 internalId, System.Object instance, System.Object[] args) [0x00012] in <eeab71685d9f4a769b786d9dc34b45cf>:0 
  at (wrapper dynamic-method) VFECore.SocialCardUtility_DrawPregnancyApproach_Patch+<>c.VFECore.SocialCardUtility_DrawPregnancyApproach_Patch+c.<AddPregnancyApproachOptions>b__4_1_Patch0(VFECore.SocialCardUtility_DrawPregnancyApproach_Patch/<>c,Verse.FloatMenuOption)
  at System.Collections.Generic.List`1[T].FindIndex (System.Int32 startIndex, System.Int32 count, System.Predicate`1[T] match) [0x0003b] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.Collections.Generic.List`1[T].FindIndex (System.Predicate`1[T] match) [0x00000] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at Verse.GenCollection.Any[T] (System.Collections.Generic.List`1[T] list, System.Predicate`1[T] predicate) [0x00000] in <cd7169108ea74757aa50c5b33d275c15>:0 
  at VFECore.SocialCardUtility_DrawPregnancyApproach_Patch.AddPregnancyApproachOptions (Verse.Pawn otherPawn, Verse.Pawn selPawnForSocialInfo, System.Collections.Generic.List`1[T] list) [0x000c6] in <4d2e96cbc8e249c7bd776f0f11cd9f48>:0 
  at (wrapper dynamic-method) RimWorld.SocialCardUtility.RimWorld.SocialCardUtility.DrawPregnancyApproach_Patch0(RimWorld.SocialCardUtility/CachedSocialTabEntry,UnityEngine.Rect,Verse.Pawn)
  at RimWorld.SocialCardUtility.DrawPawnRow (System.Single y, System.Single width, RimWorld.SocialCardUtility+CachedSocialTabEntry entry, Verse.Pawn selPawnForSocialInfo) [0x003a1] in <cd7169108ea74757aa50c5b33d275c15>:0 
  at (wrapper dynamic-method) RimWorld.SocialCardUtility.RimWorld.SocialCardUtility.DrawRelationsAndOpinions_Patch1(UnityEngine.Rect,Verse.Pawn)
  at RimWorld.SocialCardUtility.DrawSocialCard (UnityEngine.Rect rect, Verse.Pawn pawn) [0x001f1] in <cd7169108ea74757aa50c5b33d275c15>:0 
  at (wrapper dynamic-method) RimWorld.ITab_Pawn_Social.RimWorld.ITab_Pawn_Social.FillTab_Patch2(RimWorld.ITab_Pawn_Social)
  at Verse.InspectTabBase+<>c__DisplayClass16_0.<DoTabGUI>b__0 () [0x00039] in <cd7169108ea74757aa50c5b33d275c15>:0  
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Mouse position stack is not empty. There were more calls to BeginScrollView than EndScrollView. Fixing. 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Multiplayer: Error writing type: Verse.FloatMenuOption, obj: FloatMenuOption(Normal (pregnancy chance x100%), enabled), obj type: Verse.FloatMenuOption 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

bottom two errors is when i was alone in the multiplayer game, so no deync but an error

@notfood
Copy link
Member

notfood commented Jan 1, 2024

It's not syncing so if you changed it, it'll lead to desync. Issue on https://github.com/rwmt/Multiplayer-Compatibility/blob/master/Source/Mods/VanillaExpandedFramework.cs#L185 They probably changed it on VFE and broke it.

SokyranTheDragon added a commit to SokyranTheDragon/Multiplayer-Compatibility that referenced this issue Jan 1, 2024
Another lambda delegate was added to the method (used for `list.Any()` predicate), which took the ordinal of the method we were syncing and basically moved it by 1.

Haven't really tested it, but the change is so tiny it should just work fine.
@notfood notfood closed this as completed in 354b90e Jan 1, 2024
@notfood
Copy link
Member

notfood commented Jan 1, 2024

Fix is on steam now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants