Account for recursive error cycles. #39
Conversation
| @@ -7,6 +7,11 @@ let squelchedLabels; | |||
| export let squelchErrorHandlerFor = null; | |||
| export let unsquelchAllErrorHandlers = null; | |||
|
|
|||
| const excludeValue = (array, val) => { | |||
There was a problem hiding this comment.
It was, uhh… that kind of morning. I'll remove it.
| const desc = reason.toString(); | ||
| const pos = recentReasons.indexOf(desc); | ||
| if (pos !== -1) { | ||
| recentReasons = recentReasons |
There was a problem hiding this comment.
This is basically making an LRU type of thing?
There was a problem hiding this comment.
Yeah, basically aiming to keep the same semantics we had before, but for multiple errors instead of just one. So wherever it appears in the list, remove it. Happy to change the data structure; this was the naïve/first-pass thing.
There was a problem hiding this comment.
Yeah, a WeakMap would presumably be fine. I don't know what the value would be – true, maybe? – but it would work.
I can pair with you and show you a couple places I've seen errors recur in our app, but the most annoying one others are likely to have seen it is a cascade of "Glimmer transaction was already begun" that can show up in some weird and surprising spots.
| @@ -7,6 +7,11 @@ let squelchedLabels; | |||
| export let squelchErrorHandlerFor = null; | |||
| export let unsquelchAllErrorHandlers = null; | |||
|
|
|||
| const excludeValue = (array, val) => { | |||
There was a problem hiding this comment.
It was, uhh… that kind of morning. I'll remove it.
| const desc = reason.toString(); | ||
| const pos = recentReasons.indexOf(desc); | ||
| if (pos !== -1) { | ||
| recentReasons = recentReasons |
There was a problem hiding this comment.
Yeah, basically aiming to keep the same semantics we had before, but for multiple errors instead of just one. So wherever it appears in the list, remove it. Happy to change the data structure; this was the naïve/first-pass thing.
Fixes #38.
@rwjblue, I'm not exactly sure what to write in the test for this. Happy to add it once I know what I should put there!