Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS version? #31

Closed
agustif opened this issue Dec 27, 2017 · 7 comments
Closed

macOS version? #31

agustif opened this issue Dec 27, 2017 · 7 comments

Comments

@agustif
Copy link

agustif commented Dec 27, 2017

Why no macOS support?

@rvpanoz
Copy link
Owner

rvpanoz commented Dec 28, 2017

Hi agustif,

I will try to support the macOS in the next release of the app. I did not include it now because I did not have the time to test it correctly on mac based systems.

@agustif
Copy link
Author

agustif commented Dec 28, 2017

@rvpanoz, sure, that totally makes sense, let me know if I can help building/testing on MacOS, thanks for the great work!

@rvpanoz
Copy link
Owner

rvpanoz commented Dec 28, 2017 via email

@rvpanoz rvpanoz self-assigned this Dec 28, 2017
@madsnedergaard
Copy link
Contributor

madsnedergaard commented Jan 12, 2018

Hey @rvpanoz, I'll have a look and see if I can help :)

@rvpanoz
Copy link
Owner

rvpanoz commented Jan 12, 2018

@madsnedergaard thank you, I really appreciate it.

@madsnedergaard
Copy link
Contributor

madsnedergaard commented Jan 13, 2018

Hmm, this wasn't quite the easy fix as I first thought ;) Actually, it was with fix-path!
Running the app in dev (through electron) works fine, the issue is that once the app is packaged we get a different environment. So executing npm -v no longer works, since $PATH is different from normal. I'll dig further and see if I can find a solution.

See the following issues for more information:
nodejs/installer#18
electron-userland/electron-builder#880 (comment)
electron/electron#7688

Here's the error message as well:
screen shot 2018-01-14 at 00 38 23

--- Update:

Installing and testing with fix-path now, I will create a pull request tomorrow :)

madsnedergaard added a commit to madsnedergaard/luna that referenced this issue Jan 14, 2018
@rvpanoz
Copy link
Owner

rvpanoz commented Jan 14, 2018

super! 👍

@rvpanoz rvpanoz assigned rvpanoz and unassigned rvpanoz Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants