Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if 2FA is required and trigger SMS if needed #5

Merged
merged 1 commit into from
Jun 5, 2014

Conversation

jeppenejsum
Copy link
Collaborator

Currently, SMS seems not to be supported for 2FA.

This PR checks for 2FA and only asks for code if required. This also triggers an SMS if 2FA is configured to use this. Uses same solution as in mislav/hub#435

@linuxus
Copy link

linuxus commented May 30, 2014

2FA still fails on my git push command... I don't have SMS but using Google Authenticator iPhone App. 2-factor Authentication works on the web portal but I don't get any prompt on the command shell:
git push origin master
fatal: Authentication failed

@jeppenejsum
Copy link
Collaborator Author

@linuxus Not sure how this is related to this repo (or this PR)

@rvagg
Copy link
Owner

rvagg commented Jun 4, 2014

@jeppenejsum could you talk me through this as someone who doesn't use SMS 2FA? Does the mere fact of doing a POST trigger an SMS to be sent?

@rvagg
Copy link
Owner

rvagg commented Jun 4, 2014

fwiw I'm happy with this, I just need to understand how it works

@jeppenejsum
Copy link
Collaborator Author

@rvagg Yes doing a POST triggers the SMS and that's how it's done in the hub application. See this commit for some details: mislav/hub@e70f7ba

rvagg added a commit that referenced this pull request Jun 5, 2014
Check if 2FA is required and trigger SMS if needed
@rvagg rvagg merged commit 6d22878 into rvagg:master Jun 5, 2014
@rvagg
Copy link
Owner

rvagg commented Jun 5, 2014

released as 0.2.0, added you as a collaborator @jeppenejsum so you can take responsibility for any bug reports from this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants