Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes [✨ FEATURE]: create a user profile page that allows to delete … #549

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

saltykheera
Copy link
Contributor

Add profile view and delete account functionality; update localization strings with appropriate style and language (i18)
fixes

image

For now added a simple Profile Page with ability to delete account on its will with password authentication
image

steps taken care of 👍

  1. i18n is maintained with appropriate language
  2. icons and styles and adjusted accordingly
  3. user can delete the account after the password is entered

#545

@marcgc21 marcgc21 added the Review Check or stud something label Jan 20, 2025
@marcgc21
Copy link
Member

@saltykheera I started with the review and everthing looks nice!
Did you check if the user is getting deleted from auth, firestore and storage? I just tried and it looks that it is still not complete. Can you complete that before merging it?

@saltykheera
Copy link
Contributor Author

@marcgc21 now the user information is being deleted from firestore and auth as well

@marcgc21
Copy link
Member

marcgc21 commented Feb 2, 2025

@saltykheera After reviewing the PR I found that it deletes both firestore and auth.
However, the user still appeared as logged and it can continue to create testes. We must log out him. After that I beliave that the PR will be completed!

@marcgc21
Copy link
Member

marcgc21 commented Feb 3, 2025

@saltykheera it seems that there is a conflict in some files due to the last PR. Can you update them? I tried your code and worked like a charm! Congratulations!

Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@marcgc21 marcgc21 self-requested a review February 7, 2025 10:00
@marcgc21 marcgc21 merged commit c04592e into ruxailab:develop Feb 7, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Check or stud something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants